Skip to content

feat: implement RayFire tools#2552

Draft
jacobrkerstetter wants to merge 22 commits intomainfrom
feat/rayfire_support
Draft

feat: implement RayFire tools#2552
jacobrkerstetter wants to merge 22 commits intomainfrom
feat/rayfire_support

Conversation

@jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Feb 3, 2026

Description

  • allow access to the internal rayfire method and return a list of impacts
  • includes: RayFire, RayFireFaces, RayFireOrdered, and RayFireOrderedUV

Issue linked

Closes #2037

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Feb 3, 2026
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner February 3, 2026 14:38
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 3, 2026
@github-actions github-actions bot added the maintenance Package and maintenance related label Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 63.55140% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.16%. Comparing base (5e25ee5) to head (b98d3b2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/tools/rayfire_tools.py 57.62% 25 Missing ⚠️
...rc/ansys/geometry/core/_grpc/_services/_service.py 33.33% 8 Missing ⚠️
...ys/geometry/core/_grpc/_services/v0/conversions.py 50.00% 2 Missing ⚠️
...ys/geometry/core/_grpc/_services/v1/conversions.py 50.00% 2 Missing ⚠️
src/ansys/geometry/core/misc/options.py 93.75% 1 Missing ⚠️
src/ansys/geometry/core/modeler.py 83.33% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5e25ee5) and HEAD (b98d3b2). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (5e25ee5) HEAD (b98d3b2)
10 3
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2552       +/-   ##
===========================================
- Coverage   94.94%   80.16%   -14.78%     
===========================================
  Files         169      169               
  Lines       14135    14185       +50     
===========================================
- Hits        13420    11372     -2048     
- Misses        715     2813     +2098

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to tests label Feb 3, 2026
@github-actions github-actions bot removed the maintenance Package and maintenance related label Feb 3, 2026
@jacobrkerstetter jacobrkerstetter removed the testing Anything related to tests label Feb 4, 2026
@jacobrkerstetter jacobrkerstetter marked this pull request as draft February 4, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jacobrkerstetter jacobrkerstetter

Labels

enhancement New features or code improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RayFire API

2 participants

@jacobrkerstetter @pyansys-ci-bot